Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip count #93 #113

Merged
merged 3 commits into from
Oct 11, 2021
Merged

feat: skip count #93 #113

merged 3 commits into from
Oct 11, 2021

Conversation

lodmfjord
Copy link
Contributor

Shows skipped if packages are not rebuilt.

@lodmfjord
Copy link
Contributor Author

One very small change.

Probably a nicer way to get package count?

ojkelly
ojkelly requested changes Oct 10, 2021
View reviewed changes
Copy link
Owner

@ojkelly ojkelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There may be a better way to get the package count, but this works.

packages/plugins/plugin-build/src/supervisor/index.ts Outdated Show resolved Hide resolved
@lodmfjord @ojkelly
Update packages/plugins/plugin-build/src/supervisor/index.ts
5374931 
Co-authored-by: Owen Kelly <owen@owenkelly.com.au>
@ojkelly ojkelly merged commit 042409a into ojkelly:main Oct 11, 2021
@lodmfjord lodmfjord deleted the show-skipped branch October 11, 2021 00:28
@ojkelly ojkelly mentioned this pull request Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojkelly ojkelly ojkelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lodmfjord @ojkelly