Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GetTickerPrice() and GetCandlePrices() in providers still returns available ticker or candle data if not all currency pairs error #25

Merged
merged 10 commits into from
Jan 31, 2023

Conversation

rbajollari
Copy link
Collaborator

@rbajollari rbajollari commented Jan 23, 2023

Description

closes: #24

  • Added two new error types in errors.go for when a provider has no ticker or candle data.
  • If any individual currency pair can't return a ticker or candle, GetTickerPrice() and GetCandlePrices() will log a warning for that pair and only return an error back if all the currency pairs it was asked to return return an error.
  • Updated provider tests to check for new error message returned from GetTickerPrice() and GetCandlePrices()
  • Create new example config for Forex rates and get rid of Forex pairs in original config since an API key is required for that config to work

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari marked this pull request as ready for review January 23, 2023 15:32
@rbajollari rbajollari requested a review from a team as a code owner January 23, 2023 15:32
oracle/types/errors.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zarazan zarazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment regarding the error numbers

@adamewozniak adamewozniak merged commit 0c8dc4d into main Jan 31, 2023
@adamewozniak adamewozniak deleted the ryan/get-ticker-candle branch January 31, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetTickerPrices() and GetCandlePrices() in providers returns nothing if one pair doesn't have price data
4 participants