fix multi project setup get_lsp_clients #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-xyz
changed the title
jan-xyz
changed the title
|
thanks :) |
cljoly
pushed a commit
to cljoly/nvim-hardline
that referenced
this pull request
Aug 7, 2022
ojroques
pushed a commit
that referenced
this pull request
Dec 27, 2023
ojroques
pushed a commit
that referenced
this pull request
Dec 27, 2023
ojroques
pushed a commit
that referenced
this pull request
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code actually ran into a problem, the client IDs are not continuous so, when you open a second project I ran into exactly this problem: neovim/neovim#14618
The problem is that the IDs are numbered from 1 counting up for every new client, so a new project starts with at least ID 2. That means that
ipairsskips the entire table and returns 0.pairsdoesn't validate indices and just iterates over the table (see here).without the fix:
Screen.Recording.2022-01-23.at.13.38.10.mov
with the fix:
Screen.Recording.2022-01-23.at.13.44.07.mov