Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): remove default hard-coded dark styles #42

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

ojvribeiro
Copy link
Owner

Resolves #33.

The hard-coded dark styles overwrites the user styles. Instead, I moved the starter template into a built-in <VulmixWelcome /> component with the dark styles. This way we keep the pages/index.vue as clean as possible and ready to be edited.

Moved `index.vue` contents into `VulmixWelcome.vue` built-in component to keep `index.vue` as minimal as possible.
@ojvribeiro ojvribeiro added the bug Something isn't working label Sep 26, 2022
@ojvribeiro ojvribeiro self-assigned this Sep 26, 2022
@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vulmix ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 8:30PM (UTC)

@ojvribeiro ojvribeiro marked this pull request as ready for review September 26, 2022 20:32
@ojvribeiro ojvribeiro merged commit 1066d4c into main Sep 26, 2022
@ojvribeiro ojvribeiro deleted the fix-remove-default-dark-style branch September 26, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default dark styles
1 participant