Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler error upgrading lightstreamer version #50

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AndreJackBia
Copy link

Fix issue #49: compile error
Upgraded lightstreamer version to 4.3.7
Updated listeners to override new abstract methods

@username77
Copy link

Fix issue #49: compile error Upgraded lightstreamer version to 4.3.7 Updated listeners to override new abstract methods

Will works now?

@AndreJackBia
Copy link
Author

AndreJackBia commented Mar 19, 2022 via email

val image = Image(imageData.getInt("Width"), imageData.getInt("Height"), imageData.getString("Uri"))
val image = Image(0,0, "");
try {
val image = Image(imageData.getInt("Width"), imageData.getInt("Height"), imageData.getString("Uri"))
Copy link

@pedroestima-sgg pedroestima-sgg Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are overriding image, remove val on this line and change val image to var on line 120

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still doesn't fix the issue around the non-updating watchlist...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a required boolean parameter to CreateSessionRequest class constructor, otherwise the request silently crashes. However, at least for me, the updates still don't occur even after

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class CreateSessionRequest(targetServer: String, polling: Boolean, cause: String?, options: InternalConnectionOptions, details: InternalConnectionDetails, delay: Long, password: String?, oldSession: String?, serverBusy: Boolean) : SessionRequest(polling, delay) {

@pedroestima-sgg
Copy link

pedroestima-sgg commented Jun 2, 2022

Does it work? I added something to the watchlist but I get no updates.

I also downloaded the old ls-javase-client:3.1.1 but I keep not getting any updates from my watchlist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants