Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to CQ-monitor:See README.OH1KH #65

Merged
merged 1 commit into from Oct 21, 2017
Merged

Changes to CQ-monitor:See README.OH1KH #65

merged 1 commit into from Oct 21, 2017

Conversation

OH1KH
Copy link
Contributor

@OH1KH OH1KH commented Sep 29, 2017

This (2.1.0-118 in my version count) has been running ok here and I have not received any bugreports from elsewhere either.
Still this does not completely resolve CPU load caused by richmemo when monitor has been on for several hours. There must be something in the units code itself.

Question1: Why we create so many forms at program start?
Some of them must be created, but some could be created only when/if needed. ( to decrease memory usage)

Question2: You use "InitCriticalSection" on several places. If I understood its function description right it should be initiated only once at main form. After that all critical sections should use that initilalization to completely halt any other parts of program running while code is in critical section. Am I wrong?

@OH1KH
Copy link
Contributor Author

OH1KH commented Oct 13, 2017

Hi!
For your information, and for me to remember, some queued pull requests waiting after this:

#1 NewQso: bugfix "Mode AUTO" checkbox does not return previous state after remote & restart

#2 BandMap: Copied checkbox "show only active band" from preferences/band map also to" band map filter"-form for quick set and reset during daily use. It is actually one kind of filter, too.

#3 ADIF/HTML export: Added button "Re/Set All" to "choose fields to export" for quick set or reset all checkboxes at one go.

#4 DXCluster/Chat: Once rejected, but suggest it again with default height 2 (=invisible). No need=No see.... Uses now cluster login callsign instead of log's callsign for collecting lines directed to user.

@ok2cqr ok2cqr merged commit 43db516 into ok2cqr:master Oct 21, 2017
@ok2cqr
Copy link
Owner

ok2cqr commented Oct 21, 2017

As far as I know, only form that are in Window menu are auto created. Maybe a few more but I don't remember why I did that.

About the critical section. I 'm not sure, I always created new one when I needed it in different context. I've never used one critical section for whole application.

Saku, PLEASE, write a short note also to CHANGELOG file, not to README.OH1KH. That file should be only on your computer, short comment should go to CHANGELOG file, the rest should be explained in help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants