-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/763 payments algorithms #1056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done ^^
…mple into task/763-payments-algorithms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @CrazedCoding!
Think this is very close to ready to merge. The charts and graphs seem to not be broken, which is great, and during my testing I only found an extraneous console.error
(see recent comment & screenshot - I recommend testing yourself in Firefox container tabs manually to catch these things).
Can you also merge master
into your PR? It will just make it easier for others to test it without having to change the dependencies multiple times.
…mple into task/763-payments-algorithms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!! 🎉🎉🎉🎉
I am preliminarily creating this PR so people can start commenting as changes are being made, in real-time.
Here is the start of the mocha tests that I am going to create for the event-based distribution approaches:
These scenarios are mathematically/algorithmically designed to throw a monkey-wrench into any so-called turing-complete-solution anyone comes up with. If these can't break your solution, nothing can, BUT:
PLEASE don't just answer these scenarios with: "SOME should go to u2, and MORE/LESS should go to u3"
Terms like SOME, MORE, and LESS do not help us approach an algorithmic/arithmatic/mathematical solution.
Until we all agree on the distribution outcome (for any point in time) of these scenarios for the group-consolidated-approach, I will continue to try to create a "base-line" pro-rating/time-weighted solution (so we at least have some sort of reference point).