Fix minor issues around the app related to #747 #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrina-p
force-pushed
the
task/772-minor-issues-with-747
branch
2 times, most recently
from
9612fe1
to
69cd052
Compare
pieer
previously approved these changes
Nov 14, 2019
sandrina-p
force-pushed
the
task/772-minor-issues-with-747
branch
from
69cd052
to
e70648d
Compare
taoeffect
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Great job @sandrina-p! I tested it and it seems to work, and I didn't notice any issues in the code either. Will defer to @pieer to squash-merge if your latest changes meet his approval! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #772