Minor improvement Chelonia #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctually-published
Silver-IT
commented
May 29, 2023
shared/domains/chelonia/internals.js
Outdated
Comment on lines
256
to
271
| const events = await sbp('chelonia/out/eventsAfter', contractID, recent || contractID) | ||
| // checks if the list of events consist of latest event | ||
| // TODO: if we use findLastIndex, it will be more clean | ||
| // but it needs upgrade Cypress version to 9.7.0 which is of bad performance | ||
| // https://docs.cypress.io/guides/references/changelog#9-7-0 | ||
| // https://github.com/cypress-io/cypress/issues/22868 | ||
| let isLatestExistance = false | ||
| for (let i = events.length - 1; i >= 0; i--) { | ||
| if (GIMessage.deserialize(events[i]).hash() === latest) { | ||
| isLatestExistance = true | ||
| break | ||
| } | ||
| } | ||
| if (!isLatestExistance) { | ||
| throw new ChelErrorUnexpected() | ||
| } |
There was a problem hiding this comment.
@taoeffect, not sure if we should use findLastIndex here, and make it much smart.
Regarding the browser compatibility of findLastIndex, we should upgrade Cypress version to 9.7.0 or use the Chrome (not Electron) as the cypress default browser in the current version 7.7.0.
I would like to hear your opinion on this.
There was a problem hiding this comment.
References
findLastIndexBrowser Compatibility
- Cypress v7.7.0 browser versions:
Electron: Chromium 94.0.4606.81, Chrome: 113, Firefox: 113
- Cypress v9.7.0 Change Log and Browser versions:
https://docs.cypress.io/guides/references/changelog#9-7-0
Electron: Chromium 100.0.4896.75 - Cypress Bad Performance issue
Cypress is running really slow after upgrading to v10 cypress-io/cypress#22868
taoeffect
requested changes
Jun 1, 2023
There was a problem hiding this comment.
Great work @Silver-IT! Nicely done! 👍 Minor changes requested.
shared/domains/chelonia/internals.js
Outdated
| } | ||
| } | ||
| if (!isLatestExist) { | ||
| throw new ChelErrorUnexpected() |
There was a problem hiding this comment.
Suggested change
| throw new ChelErrorUnexpected() | |
| throw new ChelErrorUnrecoverable(`expected hash ${latest} in list of events for contract ${contractID}`) |
shared/domains/chelonia/internals.js
Outdated
| // but it needs upgrade Cypress version to 9.7.0 which is of bad performance | ||
| // https://docs.cypress.io/guides/references/changelog#9-7-0 | ||
| // https://github.com/cypress-io/cypress/issues/22868 | ||
| let isLatestExist = false |
There was a problem hiding this comment.
Suggested change
| let isLatestExist = false | |
| let latestHashFound = false |
shared/domains/chelonia/internals.js
Outdated
Comment on lines
258
to
261
| // TODO: if we use findLastIndex, it will be more clean | ||
| // but it needs upgrade Cypress version to 9.7.0 which is of bad performance | ||
| // https://docs.cypress.io/guides/references/changelog#9-7-0 | ||
| // https://github.com/cypress-io/cypress/issues/22868 |
There was a problem hiding this comment.
Suggested change
| // TODO: if we use findLastIndex, it will be more clean | |
| // but it needs upgrade Cypress version to 9.7.0 which is of bad performance | |
| // https://docs.cypress.io/guides/references/changelog#9-7-0 | |
| // https://github.com/cypress-io/cypress/issues/22868 | |
| // TODO: using findLastIndex, it will be more clean but it needs Cypress 9.7+ which has bad performance | |
| // https://docs.cypress.io/guides/references/changelog#9-7-0 | |
| // https://github.com/cypress-io/cypress/issues/22868 |
shared/domains/chelonia/internals.js
Outdated
| @@ -253,7 +253,22 @@ export default (sbp('sbp/selectors/register', { | |||
| if (latest !== recent) { | |||
| console.debug(`[chelonia] Synchronizing Contract ${contractID}: our recent was ${recent || 'undefined'} but the latest is ${latest}`) | |||
| // TODO: fetch events from localStorage instead of server if we have them | |||
| const events = await sbp('chelonia/out/eventsSince', contractID, recent || contractID) | |||
| const events = await sbp('chelonia/out/eventsAfter', contractID, recent || contractID) | |||
| // checks if the list of events consist of latest event | |||
There was a problem hiding this comment.
Suggested change
| // checks if the list of events consist of latest event | |
| // Sanity check: verify event with latest hash exists in list of events |
| hooks && hooks.postpublish && hooks.postpublish(message) | ||
| hooks?.prepublish?.(message) | ||
| message = await sbp('chelonia/private/out/publishEvent', message, publishOptions) | ||
| hooks?.postpublish?.(message) |
There was a problem hiding this comment.
Nice, I love this simplification of using ?. and how you added it to many places in the code that needs it!
Comment on lines
+225
to
+226
| config.postOp?.(message, state) | ||
| config[`postOp_${opT}`]?.(message, state) |
taoeffect
deleted the
1599-postpublish-should-be-given-message-actually-published
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes