Improve destructuring sequences #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
okamsn
commented
Apr 6, 2022
okamsn
commented
- Add more tests
- Reporting some things which should have been errors
- Add small optimizations for a few common cases
okamsn
force-pushed
the
destr-ignore-improve
branch
from
4f006e6
to
eca3e7e
Compare
okamsn
force-pushed
the
destr-ignore-improve
branch
10 times, most recently
from
1998441
to
47ea425
Compare
…king. - Document ignoring variables in the Org doc. - Document the alternative symbol `&keys` when searching for keys in property lists (plists). - Link to the section "Basic Destructuring" in the section on destructuring macros. - Improve error checking for destructuring lists and arrays. For example, make sure that a variable is named after `&rest` and make sure that keys are actually given after `&key`. - Better skip ignored variables at the beginning and end of sequences. - Add slight optimizations for some common cases. For example, when only 1 positional variable is used or when only using a `&rest` variable. - Error when no bindings produced. - Test that destructuring functions correctly signal an error for bad inputs. - Test that destructuring functions produce the correct bindings.
okamsn
force-pushed
the
destr-ignore-improve
branch
from
47ea425
to
9db4f2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.