Improve efficiency for constant values and various clean-ups. #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okamsn
added a commit
that referenced
this pull request
Nov 8, 2023
- Add `loopy--instr-let-var*`, `loopy--instr-let-const*`,
`loopy--instr-let-var`, `loopy--instr-let-const`. These macros are similar
to `macroexp-let2*` in that the `const` versions try to pass constant values
directly without creating a variable in the Loopy expansion.
- Update `array`, `array-ref`, `cons`, `list`, `list-ref`,
`seq`, `seq-ref`, `seq-index`, `adjoin`, `union`, `nunion`
- Don't update `numbers` until after we remove the non-keyword args.
- Replace some uses of `seq-let` with `cl-destructuring-bind`.
- Use `loopy--bind-main-body` in some places.
- Add some TODOs.
- Fix `list-ref` tests to not modify literal constant list.
- Fix `seq-ref` tests to not modify literal constant list.
- Make `loopy--find-start-by-end-dir-vals` return the test function.
- Add `:test` to `array`, `array-ref`, `sequence`, `sequence-index`, and
`sequence-ref`.
- When going up on lists, use `nthcdr` instead of `elt`.
- Add `sequence`, `sequence-ref`, `sequence-index`, `array`, and `array-ref`
tests for `:downfrom` and `:upfrom` as needed.
See also issue #176 and this PR #180.
okamsn
force-pushed
the
review-constants
branch
from
d16a42e
to
eef6a5a
Compare
okamsn
added a commit
that referenced
this pull request
Nov 8, 2023
- Add `loopy--instr-let-var*`, `loopy--instr-let-const*`,
`loopy--instr-let-var`, `loopy--instr-let-const`. These macros are similar
to `macroexp-let2*` in that the `const` versions try to pass constant values
directly without creating a variable in the Loopy expansion.
- Update `array`, `array-ref`, `cons`, `list`, `list-ref`,
`seq`, `seq-ref`, `seq-index`, `adjoin`, `union`, `nunion`
- Don't update `numbers` until after we remove the non-keyword args.
- Replace some uses of `seq-let` with `cl-destructuring-bind`.
- Use `loopy--bind-main-body` in some places.
- Add some TODOs.
- Fix `list-ref` tests to not modify literal constant list.
- Fix `seq-ref` tests to not modify literal constant list.
- Make `loopy--find-start-by-end-dir-vals` return the test function.
- Add `:test` to `array`, `array-ref`, `sequence`, `sequence-index`, and
`sequence-ref`.
- When going up on lists, use `nthcdr` instead of `elt`.
- Add `sequence`, `sequence-ref`, `sequence-index`, `array`, and `array-ref`
tests for `:downfrom` and `:upfrom` as needed.
See also issue #176 and this PR #180.
okamsn
force-pushed
the
review-constants
branch
from
eef6a5a
to
da68efe
Compare
okamsn
added a commit
that referenced
this pull request
Nov 8, 2023
- Add `loopy--instr-let-var*`, `loopy--instr-let-const*`,
`loopy--instr-let-var`, `loopy--instr-let-const`. These macros are similar
to `macroexp-let2*` in that the `const` versions try to pass constant values
directly without creating a variable in the Loopy expansion.
- Update `array`, `array-ref`, `cons`, `list`, `list-ref`,
`seq`, `seq-ref`, `seq-index`, `adjoin`, `union`, `nunion`
- Don't update `numbers` until after we remove the non-keyword args.
- Replace some uses of `seq-let` with `cl-destructuring-bind`.
- Use `loopy--bind-main-body` in some places.
- Add some TODOs.
- Fix `list-ref` tests to not modify literal constant list.
- Fix `seq-ref` tests to not modify literal constant list.
- Make `loopy--find-start-by-end-dir-vals` return the test function.
- Add `:test` to `array`, `array-ref`, `sequence`, `sequence-index`, and
`sequence-ref`.
- When going up on lists, use `nthcdr` instead of `elt`.
- Add `sequence`, `sequence-ref`, `sequence-index`, `array`, and `array-ref`
tests for `:downfrom` and `:upfrom` as needed.
See also issue #176 and this PR #180.
okamsn
force-pushed
the
review-constants
branch
2 times, most recently
from
3af3f29
to
d8a225e
Compare
… various clean-ups.
- Add `loopy--instr-let-var*`, `loopy--instr-let-const*`,
`loopy--instr-let-var`, `loopy--instr-let-const`. These macros are similar
to `macroexp-let2*` in that the `const` versions try to pass constant values
directly without creating a variable in the Loopy expansion.
- Update `array`, `array-ref`, `cons`, `list`, `list-ref`,
`seq`, `seq-ref`, `seq-index`, `adjoin`, `union`, `nunion`
- Don't update `numbers` until after we remove the non-keyword args.
- Replace some uses of `seq-let` with `cl-destructuring-bind`.
- Use `loopy--bind-main-body` in some places.
- Add some TODOs.
- Fix `list-ref` and `seq-ref` tests to not modify literal constant list.
- Make `loopy--find-start-by-end-dir-vals` return the test function.
- Add `:test` to `array`, `array-ref`, `sequence`, `sequence-index`, and
`sequence-ref`.
- When going up on lists, use `nthcdr` instead of `elt`.
- Add `sequence`, `sequence-ref`, `sequence-index`, `array`, and `array-ref`
tests for `:downfrom` and `:upfrom` as needed.
See also topics #170, #176, #178, and this PR #180.
okamsn
force-pushed
the
review-constants
branch
from
d8a225e
to
52cc6ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only evaluate values like
:testand:byonce.Add
loopy--instr-let-var*,loopy--instr-let-const*,loopy--instr-let-var,loopy--instr-let-const. These macros are similarto
macroexp-let2*in that theconstversions try to pass constant valuesdirectly without creating a variable in the Loopy expansion.
Update
array,array-ref,cons,list,list-ref,seq,seq-ref,seq-index,adjoin,union,nunionDon't update
numbersuntil after we remove the non-keyword args.Replace some uses of
seq-letwithcl-destructuring-bind.Use
loopy--bind-main-bodyin some places.Add some TODOs.
Fix
list-reftests to not modify literal constant list.Fix
seq-reftests to not modify literal constant list.Make
loopy--find-start-by-end-dir-valsreturn the test function.Add
:testtoarray,array-ref,sequence,sequence-index, andsequence-ref.nthcdrinstead ofelt.Add
sequence,sequence-ref,sequence-index,array, andarray-reftests for
:downfromand:upfromas needed.