Improve destructuring #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okamsn
force-pushed
the
destr-&optional
branch
from
3d5ba46
to
6560187
Compare
okamsn
force-pushed
the
destr-&optional
branch
4 times, most recently
from
163707d
to
8e10067
Compare
okamsn
force-pushed
the
destr-&optional
branch
2 times, most recently
from
6e4835e
to
6df1b39
Compare
okamsn
force-pushed
the
destr-&optional
branch
15 times, most recently
from
4ff3258
to
63f92a0
Compare
# Basic Changes
- Update README and CHANGELOG.
- Add destructuring features
- Re-implement destructuring using `pcase`.
# More Details
## All Constructs
- Re-implement destructuring of normal values using `pcase`, reducing the
maintenance burden and making further improvements easier.
- Make it so that the existing destructuring features will signal
an error if the `pcase` pattern doesn't match, instead of failing silently
as in `pcase`.
- Support full forms being vectors as well as lists.
## `&key`
- Improve `&key`:
- Make `&key` signal an error when there are unmatched keys in the property
list.
- Add `&allow-other-keys`.
- Support the full form `((KEY VAR) DEFAULT SUPPLIED)`.
## `&map`
- Add `&map` as `(KEY VAR DEFAULT SUPPLIED)`.
- Add `&optional` form `(VAR DEFAULT SUPPLIED)`.
- Rename `loopy--parse-destructuring-accumulation-command`
to `loopy--parse-destructuring-accumulation-command-default`
- Remove alias `loopy--destructure-generalized-variables`
from `loopy--destructure-generalized-sequence`
## New Files
- Move some destructuring features from `loopy-misc.el` to
`loopy-destructure.el`.
- Move some instruction features from `loopy-misc.el` to
`loopy-instr.el`
## Test Changes
- Add many tests.
- Update the `Makefile`.
- Only test the most recent minor version of each major version.
## Removed Features
- Remove the following functions:
- `loopy--every-other`
- `loopy--split-list-before`
- `loopy--split-off-last-var`
- `loopy--destructure-sequence`
- `loopy--destructure-list`
- `loopy--destructure-array`
- `loopy--generate-inc-idx-instructions`
## Added Features
- Add the following functions:
- `loopy-seq--make-pcase-pattern`
- `loopy--get-var-groups`
- `loopy--get-&key-spec`
- `loopy--get-&map-spec`
- `loopy--get-&aux-spec`
- `loopy--get-var-pattern`
- `loopy--pcase-pat-positional-list-pattern`
- `loopy--pcase-pat-positional-array-pattern`
- `loopy--pcase-pat-&key-pattern`
- `loopy--pcase-pat-&map-pattern`
- `loopy--pcase-pat-&aux-pattern`
- `loopy--pcase-destructure-for-iteration`
- `loopy--pcase-destructure-for-with-vars`
- `loopy--pcase-parse-for-destructuring-accumulation-command`
okamsn
force-pushed
the
destr-&optional
branch
from
63f92a0
to
3c58a51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&keyto support the full syntax (((KEY VAR) DEFAULT SUPPLIED), etc.)and add
&allow-other-keys. Make a breaking change to&keyto use
&allow-other-keysand to stop being permissive.&optionalwith the full syntax ((VAR DEFAULT SUPPLIED), etc.)&mapwith full syntax taking frommap-elt((KEY VAR DEFAULT))