Add checked usize arithmetic for Matrix indexing, make clippy fixes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okaneco
added
bug
Change get/get_mut for Matrix2d and Matrix3d to use checked math, this alters the behavior of the algorithm Change ok_or_else for Error to ok_or Remove unwraps Update cargo dependencies Update Cargo.toml exclude Bump crate version to 0.1.2 Update changelog Add build status icon to readme Change main.rs to use non-deprecated `image` function Note on expects: - some exist in Matrix2d and the SpatialQuant trait - will be removed on the next breaking version change
okaneco
force-pushed
the
checked-math-clippy-fixes
branch
from
f7d236e
to
df03dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change get/get_mut for Matrix2d and Matrix3d to use checked math, this alters the behavior of the algorithm
Change ok_or_else for Error to ok_or
Remove unwraps
Update cargo dependencies
Update Cargo.toml exclude
Bump crate version to 0.1.2
Update changelog
Add build status icon to readme
Change main.rs to use non-deprecated
imagefunctionNote on expects: