Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: evm ut addr odd length #634

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

RevelationOfTuring
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-io
Copy link

Codecov Report

Merging #634 (7261ca4) into dev (24eeed1) will increase coverage by 7.07%.
The diff coverage is 88.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #634      +/-   ##
==========================================
+ Coverage   66.68%   73.75%   +7.07%     
==========================================
  Files         307      288      -19     
  Lines       19115    17316    -1799     
==========================================
+ Hits        12747    12772      +25     
+ Misses       5639     3813    -1826     
- Partials      729      731       +2     
Impacted Files Coverage Δ
x/evm/types/state_transition.go 90.34% <80.00%> (-0.84%) ⬇️
x/evm/types/msg.go 93.12% <89.65%> (-1.08%) ⬇️
x/evm/handler.go 91.60% <100.00%> (+0.05%) ⬆️
x/evm/keeper/keeper.go 93.10% <100.00%> (ø)
x/evm/keeper/querier.go 62.50% <100.00%> (-0.49%) ⬇️
app/rpc/types/block.go
app/rpc/namespaces/personal/api.go
app/rpc/backend/backend.go
app/rpc/namespaces/eth/filters/api.go
app/rpc/namespaces/net/api.go
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2459273...7261ca4. Read the comment docs.

@zhongqiuwood zhongqiuwood merged commit 590548a into dev Feb 5, 2021
@zhongqiuwood zhongqiuwood deleted the michael.w/evm-types-ut-odd-length branch February 5, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants