-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI to check pull-requests #11
Comments
Could it be Travis CI? Or, do you want any specific CI ? |
Nothing specific at this moment ; ) |
Okay. |
Hi again. I did one really simple Travis. Which I simply run the tests as it was described on the readme. However, it raises
I wonder if you could give me a hand on this. |
To be clear, I just run: |
Many thanks, @amadeu01 – it looks like you've catch some lines that weren't updated after last change in the architecture. I've changed two lines and now tests are passing: diff --git a/api/candidates/tests/test_views.py b/api/candidates/tests/test_views.py
index d44b26e..ee25b77 100644
--- a/api/candidates/tests/test_views.py
+++ b/api/candidates/tests/test_views.py
@@ -3,7 +3,7 @@ import json
import pytest
from mongoengine.errors import NotUniqueError
-from candidates.models import Candidates
+from models import Candidates
@pytest.fixture
diff --git a/api/candidates/views.py b/api/candidates/views.py
index a58fd4d..9acc84d 100644
--- a/api/candidates/views.py
+++ b/api/candidates/views.py
@@ -4,7 +4,7 @@ from restless.dj import DjangoResource
from restless.preparers import FieldsPreparer
from restless.serializers import JSONSerializer
-from .models import Candidates
+from models.candidates import Candidates
class CandidateResource(DjangoResource): |
Okay, I’ll keep on the travis script.
|
I would suggest you to incorporate these fixes in your PR. They are important to make sure the Travis CI is working as expected ; ) |
Okay!
No problem, thanks!
…Sent from my iPhone
On 23 Jul 2018, at 15:57, Eduardo Cuducos ***@***.***> wrote:
Okay, I’ll keep on the travis script.
I would suggest you to incorporate these fixes in your PR. They are important to make sure the Travis CI is working as expected ; )
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@cuducos don’t you think that would be better to make those fixes on another PR? |
I think either way would be just fine. |
As commented on issue okfn-brasil#11, there was misspellig at and
Working ; ) |
The text was updated successfully, but these errors were encountered: