You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Surely I can fix that, but before I would like to know more about the context of these changes.
My point is: as tests weren't updated, code edits were not mentioned or justified, and no one in the PR discussion seemed to worry about the CI being red I am not sure if this new state is intentional. Therefore I don't know the direction the fix should go:
Should the tests be updated to match the code state after the PR being merged?
Or should the code edited in the PR be reverted (keeping only the docs update)?
The purpose was just to update the README to make easier e clearer the setup process. The only code change was made because we understanding it was in this context too. All changes was intended.
We only done the manual test, and it worked.
The test was not updated just for my fail. They must updated, too.
Thanks for review and fixes in #161 . They was really need.
PR #142 is a bit awkward to me. The description has no context or purpose for the changes, which break the tests:
Surely I can fix that, but before I would like to know more about the context of these changes.
My point is: as tests weren't updated, code edits were not mentioned or justified, and no one in the PR discussion seemed to worry about the CI being red I am not sure if this new state is intentional. Therefore I don't know the direction the fix should go:
cc people involved in that PR @adorilson @dehatanes @BrunaNayara @julianyraiol @sergiomario
also cc @giuliocc
The text was updated successfully, but these errors were encountered: