Fixes related to #142 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuducos
force-pushed
the
update-tests-after-pr-142
branch
5 times, most recently
from
3110ca6
to
0576e92
Compare
According to Django docs[1]: > If it’s set to False, any object can be passed for serialization > (otherwise only dict instances are allowed) As we are using a dict, there's no need for the safe=False. [1] https://docs.djangoproject.com/en/3.2/ref/request-response/#jsonresponse-objects
Aligns with changes from #142
cuducos
force-pushed
the
update-tests-after-pr-142
branch
from
0576e92
to
56b3a66
Compare
ogecece
approved these changes
Jul 14, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the question raised in #160, these changes follow the option to keep the changes in the code and update the tests to match this new state.
UPDATE as the CI was still red due to security issues with Django and
aiohttp, I'm bringing in some updates suggested in #159.