Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action para gerar lista de Contribuidores #184

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

GitHub Action para gerar lista de Contribuidores #184

wants to merge 24 commits into from

Conversation

nkzren
Copy link

@nkzren nkzren commented Oct 5, 2023

Português (BR) | English (US)

Comunidade

Tipo de alteração

  • 🐞 Correção de problema
  • ✨ Melhoria ou nova funcionalidade
  • 📰 Nova postagem no blog

Issues relacionadas

#177

Validação

  • Validei a alteração no link gerado pelo bot da Netlify (Deploy Preview/Preview on mobile)
  • Validei o Layout responsivo (desktop/mobile) após a implementação
  • Verifiquei o registro do deploy (Latest deploy log) e nenhum novo alerta ou erro foi adicionado

Evidências

Anexe evidências do antes e do depois da alteração (quando necessário).

Documentação

  • A documentação deste repositório foi atualizada (quando necessário).
  • Esta alteração requer que a documentação externa seja atualizada.

@netlify
Copy link

netlify bot commented Oct 5, 2023 •
edited

✅ Deploy Preview for querido-diario-plataforma ready!

Name Link
🔨 Latest commit f4ab60d
🔍 Latest deploy log https://app.netlify.com/sites/querido-diario-plataforma/deploys/6526007468bef7000860450e
😎 Deploy Preview https://deploy-preview-184--querido-diario-plataforma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nkzren nkzren marked this pull request as ready for review October 5, 2023 03:29
ogecece
ogecece requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@ogecece ogecece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito legal @nkzren ! Tenho alguns comentários a fazer caso a gente siga. Vamos discutindo lá na issue

.github/actions/okfn-contributors/Dockerfile Outdated Show resolved Hide resolved
.github/actions/okfn-contributors/Dockerfile Outdated Show resolved Hide resolved
.all-contributorsrc Outdated Show resolved Hide resolved
.github/actions/okfn-contributors/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/update-contributors.yaml Outdated Show resolved Hide resolved
CONTRIBUTORS.md Outdated Show resolved Hide resolved
@nkzren nkzren force-pushed the contributors-action branch 2 times, most recently from 19ee8f4 to 77271c9 Compare October 6, 2023 21:18
@nkzren nkzren requested a review from ogecece October 6, 2023 21:25
ogecece
ogecece requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ogecece ogecece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tá bem legal! Levantando mais dois pontos aqui:

.github/workflows/update-contributors.yaml Outdated
name: Atualiza CONTRIBUTORS
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/okfn-contributors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reparei agora no nome do diretório da action.

O "okfn" na verdade se refere à Open Knowledge Foundation (organização internacional). Enquanto "okbr" se refere à Open Knowledge Brasil (capítulo nacional).

Pensei em pedir pra mudar para okbr-contributors mas também vejo como opções aqui qd-contributors, querido-diario-contributors ou simplesmente contributors.

O que acha?

Suggested change
- uses: ./.github/actions/okfn-contributors
- uses: ./.github/actions/contributors

.github/actions/okfn-contributors/entrypoint.sh Outdated
all-contributors check --config $GITHUB_WORKSPACE/.all-contributorsrc \
| sed -n '2p' \
| sed 's/, /\n/g' \
| xargs -I {} all-contributors add --config $GITHUB_WORKSPACE/.all-contributorsrc {} doc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pelo que entendi estamos adicionando todas pessoas que já tem commits no projeto mas ainda não estão no .all-contributorsrc como doc, certo?

Nesse caso prponho que o padrão seja code,doc.

cc @lguima que levantou a questão lá na issue.

Suggested change
| xargs -I {} all-contributors add --config $GITHUB_WORKSPACE/.all-contributorsrc {} doc
| xargs -I {} all-contributors add --config $GITHUB_WORKSPACE/.all-contributorsrc {} code

@nkzren nkzren force-pushed the contributors-action branch 4 times, most recently from f1fdcd0 to 43bc5fd Compare October 10, 2023 00:27
@nkzren nkzren requested a review from ogecece October 11, 2023 02:20
@tigreped
Copy link
Collaborator

@ogecece essa aqui tá pronta pro merge então?

@ogecece
Copy link
Member

ogecece commented Oct 26, 2023

@ogecece essa aqui tá pronta pro merge então?

Ainda não. Avisei no último comentário lá na #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogecece ogecece Awaiting requested review from ogecece

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nkzren @tigreped @ogecece @trevineju