Gives a more meaningful name for fit test on election expenses classi…

…fier
okfn-brasil · Oct 27, 2017 · beceb14 · beceb14
1 parent 3283d8b
commit beceb14
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/rosie/chamber_of_deputies/classifiers/election_expenses_classifier.py b/rosie/chamber_of_deputies/classifiers/election_expenses_classifier.py
@@ -15,7 +15,7 @@ class ElectionExpensesClassifier(TransformerMixin):
     """
 
     def fit(self, dataframe):
-        return self
+        pass
 
     def transform(self, dataframe=None):
         pass

diff --git a/rosie/chamber_of_deputies/tests/test_election_expenses_classifier.py b/rosie/chamber_of_deputies/tests/test_election_expenses_classifier.py
@@ -23,8 +23,8 @@ def test_is_not_election_company(self):
 
         self.assertEqual(prediction_result[1], False)
 
-    def test_fit(self):
-        self.assertEqual(self.election_expenser_classifier.fit(self.dataframe), self.election_expenser_classifier)
+    def test_fit_just_for_formality_because_its_never_used(self):
+        self.assertTrue(self.election_expenser_classifier.fit(self.dataframe) is None)
 
     def test_transform_just_for_formality_because_its_never_used(self):
         self.assertTrue(self.election_expenser_classifier.transform() is None)