Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPI label to README.rst #149

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Add PyPI label to README.rst #149

merged 1 commit into from
Oct 2, 2017

Conversation

marius92mc
Copy link
Contributor

What is the purpose of this Pull Request?
Fixes #148.

What was done to achieve this purpose?
Add a URL to the mentioned label.

How to test if it really works?
See README.rst.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.278% when pulling 7e8e2dc on marius92mc:add-pypi-label-to-readme into 3bb7358 on datasciencebr:master.

@giovanisleite giovanisleite mentioned this pull request Oct 2, 2017
@marius92mc
Copy link
Contributor Author

Should this be merged in this state knowing the coverage remained at that rate, @giovanisleite?

@giovanisleite
Copy link
Contributor

Should this be merged in this state knowing the coverage remained at that rate, @giovanisleite?

Yes, the coverage and the travis error are not related to this issue.

I don't know if it is necessary to bump the version, but @jtemporal can tell you.

@marius92mc
Copy link
Contributor Author

Yeah, I also think it is not needed to bump the version.

@giovanisleite
Copy link
Contributor

Yeah we are trying to have a at least a minor bump version for any change in this project. :)

Actually, the readme/documentation is part of the project, so.. i think it is

@marius92mc
Copy link
Contributor Author

Alright, @giovanisleite, I bumped the version.

@cuducos
Copy link
Collaborator

cuducos commented Oct 2, 2017

Regarding the version bump issue, it's written in the README.md:

Always suggest a version bump.

Always. Because every new code merged into master triggers the CI. And then the CI triggers a new release to PyPI. And this would ruin the whole project (omg I'm so dramatic…) hahaha… anyway, no, that's not a big big problem. But it's important to understand that not bumping the version will break something, and it's also important to understand why it breaks something.

So unless you add [skip ci] to your commit message, yes, bumping version is required ; )

@cuducos cuducos merged commit 339de28 into okfn-brasil:master Oct 2, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.278% when pulling 522cac4 on marius92mc:add-pypi-label-to-readme into 3bb7358 on datasciencebr:master.

@cuducos cuducos mentioned this pull request Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants