Allow user to disable LOG_FILE handler #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we already set the LOG_FILE configuration variable by default, there was no
way for the user to disable having a log file. Even if she tried to do
LOG_FILE = None
It won't work, because logging.handlers.RotatingFileHandler() throws an error
when called with None. Even if it worked, we still added this handler a few
lines down, because we were checking if there was a LOG_FILE key in the config
file (which is always true, given that we set it by default and there's no way
IMHO to delete it)
With this patch, we only create the file handler if there is a
RotatingFileHandler, and it's trueish.
|
AFAIK, the only way to "disable" the LOG_FILE right now is to set it to |
Merged
|
Done in #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we already set the LOG_FILE configuration variable by default, there was no
way for the user to disable having a log file. Even if she tried to do
It won't work, because logging.handlers.RotatingFileHandler() throws an error
when called with None. Even if it worked, we still added this handler a few
lines down, because we were checking if there was a LOG_FILE key in the config
file (which is always true, given that we set it by default and there's no way
IMHO to delete it)
With this patch, we only create the file handler if there is a
RotatingFileHandler, and it's trueish.