[#669] Raise NotFound if group is not found in member_list.

Allows a proper error to be generated in the API
controller instead of just giving a 500 error.

ckan/logic/action/get.py

@@ -262,6 +262,9 @@ def member_list(context, data_dict=None):
     model = context['model']
 
     group = model.Group.get(_get_or_bust(data_dict, 'id'))
+    if not group:
+        raise NotFound
+
     obj_type = data_dict.get('object_type', None)
     capacity = data_dict.get('capacity', None)
 

ckan/tests/logic/test_member.py

@@ -1,3 +1,5 @@
+from nose.tools import assert_raises
+import ckan.logic as logic
 from ckan import model
 from ckan.logic import get_action
 from ckan.lib.create_test_data import CreateTestData
@@ -50,6 +52,10 @@ def test_member_list(self):
         res = get_action('member_list')(ctx, dd)
         assert len(res) == 0, res
 
+        ctx, dd = self._build_context('', 'user', 'admin')
+        dd['id'] = u'foo'
+        assert_raises(logic.NotFound, get_action('member_list'), ctx, dd)
+
         self._add_member(self.username, 'user', 'admin')
         ctx, dd = self._build_context('', 'user', 'admin')
         res = get_action('member_list')(ctx, dd)