Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[2375] Update the pagination in helpers.py
No longer wrapping the ".." link in a span to output valid HTML. Also added the "pagination-centered" class.
- Loading branch information
Showing
1 changed file
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f588587
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aron
is there something we can do here that doesn't touch helpers.py? this is common code for all ckan users so I'm keen to remove any specifics from it as this leads to 'fights'. I'd be nice if we could add stuff via parameters or templates to avoid these problems.
cheers
f588587
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tobes absolutely, if we could split it out into a snippet that would be amazing. Not 100% sure how to go about this.
The change on line 562 actually fixes a bug that was causing a
<li>
element to be inserted inside a<span>
. So that can stay.Also you can comment directly on lines of code in these GitHub pages by clicking the little comment button that appears when you hover over a line. This makes it easier to see what you're talking about.