Add group members page to templates

[johnmartin]

To edit a group's members you have to go to /group/members/my-group, but there's no link to this anywhere.

[frank0051]

I can confirm this - I thought they were trying to do away with group permissions when orgs were introduced, but it doesn't seem like it.

[johnmartin]

FYI: I know that the buttons overlap on this... but this will be answered with #890

[seanh]

This seems wrong to me, because it's different from how the organization page works.

1. The members tab is shown on /group/foobar, but on an organization's page I have to click on the Admin button first and then the members tab is shown on /organization/edit/foobar.
2. On the groups page the members tab (including edit and delete buttons) is shown to users who aren't a member of the group
3. With organizations, if I'm not a member of an org I cannot see a list of who the members are (because I don't get the Admin button). Maybe I can get it via the API, not sure, but not via the UI anyway. I don't know why this is this way for organizations but presumably the decision was made for a reason and it may as well be the same for groups.

[johnmartin]

@seanh Aha! Good point. I think I misunderstood that point of this issue. I was assuming that we simply wanted the members page back in as of 1.8. But in reality we want a replica of the org admin pages. I'll re-write this, thanks for the feedback.

[johnmartin]

I'm moving this to 2.2 as it's unlikely that'll be able to get this complete for the tomorrows deadline to branch from master. I'll most likely get to this on Tuesday, so we might be able to squeeze into 2.1 anyways, but I don't want this to block 2.1.

[johnmartin]

OK, well... I had time in the end to get this ready for 2.1, so I've tweaked the pull request based on the feedback.

[seanh]

I've edited the new group member form to make it more similar to the one for organizations.

There's still a few more differences:

1. I noticed that the button on the group read page is Edit but on the organization read page it's Admin, which is right?
2. The organization page title is Edit Organization but the group one is Edit a Group
3. The organization page title is Members - My Organization - CKAN but the groups one is just My Group - CKAN
4. The group breadcrumbs are wrong, they're just "/ Group / Edit Group" should be "/ Group / My Group / Edit Group" (or in the case of organization it's Admin not Edit Organization, these should be consistent)
5. Organization's admin page has a datasets tab group one doesn't

@johnmartin Up to you if you want to fix any of the above in this pull request for 2.1 or not, I'm happy for new 2.2 issues to be made out of them, especially because it looks like the groups templates (and the groups feature generally) need a bit of an overhaul.

I also noticed that the organization read page shows the number of datasets in the sidebar, but the group one doesn't (not related to this pull request, I guess).

It looks like there are a lot of very similar template files for groups and organizations, and by duplicating them random differences like this get in. I wonder if they should be combined into single template files?

[johnmartin]

@seanh

1. I noticed that the button on the group read page is Edit but on the organization read page it's Admin, which is right?

"Edit" is right. But #1030 will answer this problem.

1. The organization page title is Edit Organization but the group one is Edit a Group

Agreed. Fixed.

1. The organization page title is Members - My Organization - CKAN but the groups one is just My Group - CKAN

Agreed, odd. I've made groups like orgs now.

1. The group breadcrumbs are wrong, they're just "/ Group / Edit Group" should be "/ Group / My Group / Edit Group" (or in the case of organization it's Admin not Edit Organization, these should be consistent)

Again, like 3.

1. Organization's admin page has a datasets tab group one doesn't

I've made a 2.2 issue #1049 that incorporates this (and some of the other elements you mentioned). As a side note: I think maybe having a generic template for orgs/groups might be a nice idea.

I've also merged master into this (since there were merge conflicts)

[seanh]

@johnmartin The tabs on the group edit page seem broken now? Merge conflict?

[johnmartin]

@seanh Yes, the template block names had changed in master. It's fixed now.