Logging out with ckan on non-root URL redirects to the wrong URL.

[tobes]

When running ckan on a non-root URL, clicking on logout ends up in a redirect which does not take the api_url into consideration.

[tobes]

loging out should not care about api_url as that is for api calls and nothing to do with where ckan is

[tobes]

@kindly this is now assigned to you as @nigelbabu nigel was not confident about reviewing it. Let me know if you want and I can do #1039 as part of this pr

[kindly]

@tobes yes could you do #1039 as part of this one and I can review

[tobes]

@kindly I've added the change - is this good enough?

[kindly]

@ tobes the problem is that any came_from we generate is always absolute so this will never work.
I think we generate the came_from here
https://github.com/okfn/ckan/blob/master/ckan/lib/repoze_patch.py#L154

[tobes]

But I think we always add the came_from ourselves - I can add logic for //ckan_domain/... if you want but in testing all was good - let me know

[kindly]

It my test going to:
http://0.0.0.0:5000/organization/new
when logged out redirects to:
http://0.0.0.0:5000/user/login?came_from=http://0.0.0.0:5000/organization/new

So this seems like it is an issue.

[tobes]

Is this better :) works for me

[tobes]

@kindly you need anything from me for this?