Fix resource proxy encoding errors #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
…ssues with chunked responses. Improve overall performance and error reporting.
|
@joetsoi Hey, I added a commit to fix issues with servers that do not support HEAD requests. |
|
@joetsoi I'm keen into get this into 2.0.1 can you review and merge at some point next week if you are happy? |
|
@domoritz This was flagged as 2.0.1 but the whole PR is not compatible with it as it was branched afterwards (eg tests in 2.0.1 don't use httpretty). If you can provide a 2.0.1 fix in a new PR I'll merge it, otherwise it would have to be 2.1 only. |
|
@amercader I can copy the changes to the resource proxy but not the tests to keep it compatible with 2.0 and send a pull request tomorrow. |
domoritz
added a commit
that referenced
this pull request
Jun 6, 2013
This was referenced Jun 6, 2013
|
@amercader Fixes for 2.0 in #980. |
domoritz
added a commit
that referenced
this pull request
Jun 26, 2013
FuhuXia
pushed a commit
to GSA/ckan
that referenced
this pull request
Mar 5, 2015
FuhuXia
pushed a commit
to GSA/ckan
that referenced
this pull request
Mar 5, 2015
FuhuXia
pushed a commit
to GSA/ckan
that referenced
this pull request
Mar 5, 2015
FuhuXia
pushed a commit
to GSA/ckan
that referenced
this pull request
Mar 5, 2015
FuhuXia
pushed a commit
to GSA/ckan
that referenced
this pull request
Mar 5, 2015
Conflicts: ckan/tests/test_coding_standards.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some resources cannot be proxied because of encoding issues. For example http://www.berlin.de/ba-lichtenberg/buergerservice/familie/tagespflege/index.php/index/all.json?q=.
The error in Firefox:
Content Encoding ErrorIn Chrome:
Error 330 (net::ERR_CONTENT_DECODING_FAILED): Unknown error.In curl:
url: (56) Problem (2) in the Chunked-Encoded data