Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow quoted dates in regex in before_index() #52

Closed
wants to merge 1 commit into from
Closed

allow quoted dates in regex in before_index() #52

wants to merge 1 commit into from

Conversation

joetsoi
Copy link
Contributor

@joetsoi joetsoi commented Feb 22, 2013

ckan branch 381-convert-from-extras-quoting allows quotes round
dates which means the regex here needs to allow them as well.

https://github.com/okfn/ckan/tree/381-convert-from-extras-quoting

ckan branch 381-convert-from-extras-quoting allows quotes round
dates which means the regex here needs to allow them as well.
@seanh
Copy link
Contributor

seanh commented Mar 4, 2013

Is there a bug here that can be reproduced, and this branch tested to see that if fixes the bug?

I'm not sure I understand the change, the regex is for parsing date strings from data publica, so this change would only be needed if datasets harvested from data publica have quotes around their date strings now. Is that what happens?

@joetsoi joetsoi closed this Mar 29, 2013
@amercader
Copy link
Member

Note that after ckan/ckan#267 the whole data publica hack is no longer needed as all _date ending fields are handled at index time in core. So basically all your before_index method can go (if you are using latest core release-v2.0)

@joetsoi
Copy link
Contributor Author

joetsoi commented Apr 2, 2013

yeah I figured as much, the before_index method actually broke because it was only expecting data publica formats and crashed out on any other see c1d7456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants