Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Download and Licence in Footer #50

Merged
merged 3 commits into from
Nov 10, 2015
Merged

JSON Download and Licence in Footer #50

merged 3 commits into from
Nov 10, 2015

Conversation

Stephen-Gates
Copy link
Contributor

Addresses #45 Licence. Please confirm single link to PDDL is sufficient
as submission form states data is licensed as both CCZero and/or PDDL

Addresses #33 and #17 JSON API in Site Footer

Stephen Gates added 2 commits August 14, 2015 21:10
JSON Download and Licence in Footer
c364044 
Addresses okfn#45 Licence. Please confirm single link to PDDL is sufficient
as submission form states data is licensed as both CCZero and/or PDDL

Addresse okfn#33 and okfn#17 JSON API in Site Footer
Link to CSV file download in footer
4514f81 
May address okfn#36. Not entirely sure on the meaning @mattfullerton
@Stephen-Gates
Copy link
Contributor Author

Download CSV may not be as simple as publish Google doc and add link in footer. Discovering weird treatment of special characters when viewing download using Excel.

@mattfullerton
Copy link
Contributor

OK, then the medium term goal should be to do it from node.js.

Do you still want the pull request merged?

@rgrp - thoughts on the license issue? Changing the form to match is simple enough.

@rufuspollock
Copy link
Member

@mattfullerton yes doing this as just PDDL is fine.

Re CSV direct google download link is fine for now. Next step (cc @Stephen-Gates) would be to Tabular Data Package-ize the CSV file by adding a datapackage.json in this repo for it ;-) see http://data.okfn.org/doc/publish-tabular

@rufuspollock
Copy link
Member

@mattfullerton i'll leave you to merge and do the deploy :-)

@Stephen-Gates
Copy link
Contributor Author

@rgrp so the next step for data packaging is to create something like https://github.com/okfn/opendatasites but in this repository? There is already a Data directory that contained (an old) CSV file that people recently issued pull requests on to change data. @mattfullerton just moved the file to Archive to avoid future pull requests.

So is everyone happy to put CSV back and add update it as part of the data release process?

I'll focus on reviewing submissions and writing documentation while you decide.

@rufuspollock
Copy link
Member

@Stephen-Gates we actually won't put the CSV back in the github repo - we'll just point to the CSV link that google docs gives us.

Update Readme
877341f 
Change Catalog to Portal. Diminish plans in Google doc by also
referring to GitHub issues and discussion forum
@Stephen-Gates
Copy link
Contributor Author

@mattfullerton can this be progressed to support this request?

rufuspollock added a commit that referenced this pull request Nov 10, 2015
@rufuspollock
Merge pull request #50 from Stephen-Gates/master
2bc470d 
JSON Download and Licence in Footer
@rufuspollock rufuspollock merged commit 2bc470d into okfn:master Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stephen-Gates @mattfullerton @rufuspollock