Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges for Local Groups in OK Forum #3

Closed
wants to merge 21 commits into from
Closed

Badges for Local Groups in OK Forum #3

wants to merge 21 commits into from

Conversation

Stephen-Gates
Copy link
Contributor

As discussed in the OK Forum, here's a set of badges for the existing local groups.

  • UK used for Scotland
  • No England directory created. Will reuse Scotland UK badge until direction set.
  • LFS no used

@rufuspollock
Copy link
Member

First, this is awesome work @Stephen-Gates

Some questions:

  • Is there any way to get badges with the actual (lower resolution) OK logo outline rather than the generic "red sun"? It should be possible i imagine and would be nice to keep that so it is the same as the logos local groups have created for twitter etc ...
  • naming files: can we always have lower case with - rather than _ for word separators? (we should be this in our coding style guide ;-) ...)
  • What is the logic of git lfs vs not git lfs (and how does git lfs work with gh-pages?)

@Stephen-Gates
Copy link
Contributor Author

@rgrp

  • I tried using the lower resolution logo as shown the forum. I thought the logo was too small to be useful on user cards.
  • I can rename the files but you'll need to rename all files in this repository if you want things to be consistent. I was just following what was already here
  • I imagine @jgkim used lfs for some of the bigger source files. I don't know how to use it so just uploaded small .png files.

I'm happy to adjust things if given stronger direction. I took Dan Fowler's encouragement on the forum as a good enough to go ahead.

I'll make I've made the Australian Badge as you describe and added it to the Forum for you to compare. Not sure what to do with transparency vs white around the "red sun".

screenshot 2016-04-02 22 55 45

@rufuspollock
Copy link
Member

@Stephen-Gates

  • Thanks for example re badge and I see the problem. I'm wondering about this solution: we make entire part inside the "green" outer ring red and then have the text as large as possible on that. Worse case we can also "chop" a bit off the longest lines on green outer ring to make it a bit bigger.
    • Is it also possible to get a comparison screenshot of a user profile with "red sun" logos?
  • at least for this lot let's use consistent lower case + '-' naming. Other stuff we can change later.

Once again this is awesome 👍

@Stephen-Gates
Copy link
Contributor Author

@rgrp
All comparison images are in the forum post apart from the one above.

I've made the logo as you suggest and changed the badge on the forum to test - IMHO it's not pretty
screenshot 2016-04-02 23 49 54
screenshot 2016-04-02 23 50 47

I'm changing it back to the original badge

@rufuspollock
Copy link
Member

@Stephen-Gates my bad - i'd somehow missed your post in the forums. My feelings is that we go with the "nice" logo (i.e. the proper one). OK on small cards it is a problem but you can still read the description so it is not a huge loss. I've commented in the forum too: https://discuss.okfn.org/t/nicer-badge-icons-images/2108/6

@rufuspollock
Copy link
Member

@Stephen-Gates ok, not sure that quite works - my sense is that for now we just go with original you did in the forum i.e. https://discuss.okfn.org/uploads/default/optimized/2X/b/bf45ccc226877d0d72381eef95ae3932cbaa1613_1_690x263.png

That is the standard logo with text in middle. I know that it will be problematic at low resolutions but i think we can iterate later and right now that is simple and means we get consistency with the existing group logos (we can even directly reuse).

@Stephen-Gates
Copy link
Contributor Author

@rgrp Will make logos in near future and add to a different PR. Closing this PR

@Stephen-Gates Stephen-Gates deleted the Stephen-Gates-Badges branch April 2, 2016 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants