Title field not being saved with submissions

[pwalsh]

The new title field is not being saved with submissions.

• Check and fix code
• Write test to prove it

[pwalsh]

Verified that it is not saved with initial submissions, but is saved when a submission is accepted and added to the Entry table.

[clkao]

I can reproduce this too.

[pwalsh]

This is a problem in one of our dependencies.

This line:

https://github.com/theoephraim/node-google-spreadsheet/blob/master/index.js#L102

Ensures that the 'title' key is stripped out of the data before it is sent to the spreadsheet, in the case of adding a new row.

I'm opening up an issue upstream for that, but for us, I'm not decided on the best course of action as yet.

@rgrp seeing as 'title' is relatively new - do you have any idea of how many instances are actually using it?

[pwalsh]

I made a pull request upstream:

theoephraim/node-google-spreadsheet#17

[pwalsh]

The issue upstream is not fixed by my pull request. Or rather, the upstream library needs deeper changes and subsequently more test coverage in order to allow column headers named 'id', 'title' or 'content'.

[loleg]

Bump. Still a rather annoying data loss problem.

[rufuspollock]

@loleg understood - unfortunately no fix upstream as yet - and so any immediate fix requires a DB migration ... - we are working on it :-)

[loleg]

If the fix will take a while and people are still using the site - how about disabling the field with a short note for the time being?

[rufuspollock]

@loleg we were hoping it would be fixed monday, then tuesday etc. We have pushed patch upstream but some issues. You are correct that we should perhaps just disable - but we would also like to fix. Will get to this in next 12h.

[loleg]

@rgrp great. I have the code running locally and have reproduced the bug, let me know if I can do any testing or so.

[pwalsh]

I'm looking at this now

[pwalsh]

Fixed in a18883a

The commit actually just has tests - all changes are in configuration of questions, submissions and entries backends.

See the commit message, also copied here:

Fixes issue with "title" by renaming to "officialtitle". Problem due to bug in dependency. Has testsm and test database has been updated with the "officialtitle" field (it did not have the "title" field either).

Steps required:

• Rename your "title" question identifier to "officialtitle"
• If "title" is a dependant field in your configuration, also rename the reference in the dependants field of the parent
• rename "title" to "officialtitle" in your submissions database
• rename "title" to "officialtitle" in your entries database
• Do /admin/reload/ with appropriate permissions

Important

In order to minimise the effect of this change, I created a new questions spreadsheet for use on the global census. This sheet has the updated "title" > "officialtitle" question. The default question spreadsheet does not. This seemed like the safest action at present. I'm creating a new issue for dealing with the generic question sheet & city census instances.