-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not display Grid View button in metadata panels #405
Conversation
guergana
commented
May 24, 2024
•
edited
Loading
edited
- fixes Remove grid view - Metadata panel #393
We might need to remove the 'Grid View' button altogether in the future if we no longer need it. I would suggest we don't remove it for now because this button is used in other panels/sections in the application. @romicolman The grid view button exists in other parts of the application as well. Do we want to remove this button from everywhere? For example, if you upload a chart. You can use the file attached to this comment... you see again the button in the metadata panels Channels, Transforms and Layers. Same for when you upload a datapackage. You can also find a data package attached to this message. I know we are centering now on tabular data but since all the app is connected it is better to know the details because the code will be different if we remove it only in tables or everywhere. |
@romicolman yes. Right now on the code I pushed I am only hiding it for tabular data. We can merge this and discuss if we need the Grid view Button at all later on if it's needed. I just wanted to bring it up since the button doesn't look very useful in the other panels either in my opinion 🙈 |
@romicolman @guergana my opinion is that Grid View is the kind of feature that do not provide greater value and makes the code unnecessarily more complex. (Since we are reusing components we need to either play around with CSS or create more hierarchies to handle the scenario.) The list view is clear enough, and I don't understand the value that provides switching between them. Yes I guess we could fix it to display the information better but I'm in favor of less features, less UIs and less code. |
Yep. I would also remove it from the whole application. Hence my question. |
Yes, please, remove the grid view from the app. |
as discussed
Deploying opendataeditor with Cloudflare Pages
|
As we discussed with Romina the Grid View is useful for tabular data having many columns |
Hi, I am confused. The grid view is a button in the metadata sections like "contributors", " licenses" etc. how is this related to the amount of columns? I have removed the grid view Button because I thought this is what the last instructions said @romicolman could you please clarify? :) |
@roll this is the last comment from the last discussion |
Please, remove grid view from all metadata fields. Thanks! |
@guergana could you as well remove the This code will be orphan since it is only triggered by the button we are removing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @guergana ! See my comment above :)
Good catch! That was an oversight. Will remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect @guergana 🚀