Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example project #339

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Remove example project #339

merged 3 commits into from
Apr 26, 2024

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Apr 22, 2024

fixes #328

I'm also renaming APP_EXAMPLE to APP_TMP to make more explicit that it is only a temporary folder.

How to test

  1. Build the application
  2. Install it
  3. Open the application (by executing the application, not by running make start)
    a. Note: make start points the project folder of the application to another folder names ./tmp/project
  4. Clean or backup your /home/<user>/.opendataeditor folder.
  5. On first time run there shouldn't be any example files loaded.
  6. The default project should point to /home/<user>/.opendataeditor/tmp

image

@pdelboca pdelboca requested review from roll and guergana April 22, 2024 09:02
Copy link

cloudflare-pages bot commented Apr 24, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 46d23b5
Status: ✅  Deploy successful!
Preview URL: https://1446952a.opendataeditor.pages.dev
Branch Preview URL: https://328-remove-example-project.opendataeditor.pages.dev

View logs

Copy link
Collaborator

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced following the steps in ubuntu and I can attest that it's working as expeted. ✔️ 💯

@pdelboca pdelboca merged commit fa4f2b3 into main Apr 26, 2024
5 checks passed
@pdelboca pdelboca deleted the 328-remove-example-project branch April 26, 2024 07:51
@romicolman romicolman mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove list of features
2 participants