-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2015 Theme - v0.1 #1
Comments
Masthead
Sidebar
Minor styling:
|
Masthead Sidebar
|
For tables (and other markdown styling), see http://new.opendatahandbook.org/contribute/markdown-examples/ |
@mintcanary is this bootstrap-based? I'd assumed so but I now realize it may not be. Like other cases we'd like this theme to be reusable and, if possible, bootstrap based so it fits with our standard setup and can be adapted easily. |
More generally, I was intending this could join our "stable" of themes at jekyll-theme. To the extent we can also share standard config options etc that is good too e.g. i assume we have configurable google analytics support built in (its just one config option) and, if so, that we run off same variable as in jekyll-theme repo. |
Not Bootstrap, no. (I'm not a fan of using Bootstrap in production, so unless there is a specific requirement for it, it isn't my default.) There are frameworks in use however: I'm not familiar with our "standard setup", so cannot comment on that. Could you give examples of what you mean by "adapted easily"? Standard config options sounds like a good idea. Analytics is not yet in the config for this theme, but obviously easy to add it. Where/what is the "jekyll-theme" repo you mention? |
jekyll theme repo: http://github.com/okfn/jekyll-template Bootstrap: 90%+ of OK sites use bootstrap => our standard setup. This commonality also creates familiarity plus the ability to reuse css and html structure. Familiarity => ease of adaptability because people are familiar, plus ability to reuse tweaks elsewhere. This also increases maintainability in the medium-term. Apologies for not making this requirement clearer as product owner earlier on. How much effort would you estimate it would be to bootstrap-ize the theme? (This is not a request to do that - just a question re effort). |
I think it would be a fairly sizeable task, but we should clarify what this means.
So I think what we are talking about is replacing the SASS library, redefining variables, and rewriting the custom SASS. I'd estimate about a day. |
FIXED. Very much done. |
* add categorise openness BP * add DC BP * add EC BP * add EF BP * lowercase * lowercase * lowercase * lowercase * add EODE BP * add EQA BP * add ft bp * add hls bp * add hm bp * add iwyap bp * add mrosrai bp * add odbm bp * add odpp bp * add pomd bp * add portal bp * add ptd bp * add sgd bp * add stats bp * add shvd bp * add su bp * add udfd bp * delete udfd bp * delete shvd * delete mrosrai * dele hls * add zero bp
v0.1
First pass at: http://okfnlabs.org/opendatahandbook-v2/en/what-is-open-data/
The text was updated successfully, but these errors were encountered: