Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2015 Theme - v0.1 #1

Closed
rufuspollock opened this issue Feb 9, 2015 · 9 comments
Closed

2015 Theme - v0.1 #1

rufuspollock opened this issue Feb 9, 2015 · 9 comments

Comments

@rufuspollock
Copy link
Member

v0.1

  • Basic theme with front page and handbook page
  • Migrate sample content from RST to markdown and jekyll

First pass at: http://okfnlabs.org/opendatahandbook-v2/en/what-is-open-data/

@rufuspollock
Copy link
Member Author

Masthead

Sidebar

  • Really nice - only concern is that it requires some complexity (e.g. JS?)
  • What about next level down in tree (e.g. parts of a chapter of the handbook)? i.e. if we have 3 levels (Module, Chapter, Section)
  • Should we highlight the section we are in in some way
  • how will this work out on mobile?

Minor styling:

  • block quotes not styled yet
  • nice to see what tables look like

@smth
Copy link
Contributor

smth commented Feb 9, 2015

Masthead
Yeah, I have done zero styling here as yet. I was thinking search could go top-right, once we have that functionality.

Sidebar

  • Yes, requires JS. I'm sure we could build in a reasonable fallback though.
  • Parts of a chapter is something I had already started working on. You can see those links in the intro section now.
  • The section is already highlighted (though not all that obviously at present).
  • On smaller screens, menu will be hidden by default, and revealed by clicking an icon (currently a text link). You can get a good idea of this by resizing your browser window.

@rufuspollock rufuspollock changed the title New Theme - v0.1 2015 Theme - v0.1 Feb 9, 2015
@smth
Copy link
Contributor

smth commented Feb 16, 2015

For tables (and other markdown styling), see http://new.opendatahandbook.org/contribute/markdown-examples/

@rufuspollock
Copy link
Member Author

@mintcanary is this bootstrap-based? I'd assumed so but I now realize it may not be.

Like other cases we'd like this theme to be reusable and, if possible, bootstrap based so it fits with our standard setup and can be adapted easily.

@rufuspollock
Copy link
Member Author

More generally, I was intending this could join our "stable" of themes at jekyll-theme. To the extent we can also share standard config options etc that is good too e.g. i assume we have configurable google analytics support built in (its just one config option) and, if so, that we run off same variable as in jekyll-theme repo.

@smth
Copy link
Contributor

smth commented Apr 22, 2015

Not Bootstrap, no. (I'm not a fan of using Bootstrap in production, so unless there is a specific requirement for it, it isn't my default.) There are frameworks in use however:

I'm not familiar with our "standard setup", so cannot comment on that. Could you give examples of what you mean by "adapted easily"?

Standard config options sounds like a good idea. Analytics is not yet in the config for this theme, but obviously easy to add it. Where/what is the "jekyll-theme" repo you mention?

@rufuspollock
Copy link
Member Author

jekyll theme repo: http://github.com/okfn/jekyll-template

Bootstrap: 90%+ of OK sites use bootstrap => our standard setup.

This commonality also creates familiarity plus the ability to reuse css and html structure. Familiarity => ease of adaptability because people are familiar, plus ability to reuse tweaks elsewhere. This also increases maintainability in the medium-term.

Apologies for not making this requirement clearer as product owner earlier on. How much effort would you estimate it would be to bootstrap-ize the theme? (This is not a request to do that - just a question re effort).

@smth
Copy link
Contributor

smth commented Apr 22, 2015

I think it would be a fairly sizeable task, but we should clarify what this means.

  • HTML: Should remain as is - semantic (should be no reference to Bootstrap, or any other framework)
  • CSS: Generated by Jekyll, from SASS. Ultimately resulting compiled CSS must remain the same (BS might add some additional, unused stuff).
  • SASS: Mixins replaced with BS specific ones. This would be where the work is, and where the impact would be on future developers.
  • JS: Largely irrelevant, as we are using (and would continue to use) third party extensions to achieve what we want.

So I think what we are talking about is replacing the SASS library, redefining variables, and rewriting the custom SASS. I'd estimate about a day.

morchickit added a commit that referenced this issue Apr 25, 2015
morchickit pushed a commit that referenced this issue May 19, 2015
morchickit pushed a commit that referenced this issue May 19, 2015
glossaryフォルダを英語版 en からコピー
@rufuspollock rufuspollock added this to the Handbook v2 milestone May 25, 2015
@rufuspollock
Copy link
Member Author

FIXED. Very much done.

morchickit pushed a commit that referenced this issue Jul 10, 2016
* add categorise openness BP

* add DC BP

* add EC BP

* add EF BP

* lowercase

* lowercase

* lowercase

* lowercase

* add EODE BP

* add EQA BP

* add ft bp

* add hls bp

* add hm bp

* add iwyap bp

* add mrosrai bp

* add odbm bp

* add odpp bp

* add pomd bp

* add portal bp

* add ptd bp

* add sgd bp

* add stats bp

* add shvd bp

* add su bp

* add udfd bp

* delete udfd bp

* delete shvd

* delete mrosrai

* dele hls

* add zero bp
morchickit pushed a commit that referenced this issue Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants