Skip to content
This repository has been archived by the owner on Aug 3, 2022. It is now read-only.

Localization for Survey #844

Closed
11 of 12 tasks
brew opened this issue Nov 28, 2016 · 0 comments
Closed
11 of 12 tasks

Localization for Survey #844

brew opened this issue Nov 28, 2016 · 0 comments
Assignees
@brew
Milestone
Survey site Post-...

Comments

@brew
Copy link
Collaborator

brew commented Nov 28, 2016 •
edited

During implementation of the new template design and survey strategy for the 2016 survey, localization wasn't explicitly supported. Much of the supporting code is in place, but new strings need to be marked for translation, and Transifex updated.

The strategy for localizing loaded content (Questions, Datasets, etc) has changed. Site admins are encouraged to manage Questions and Datasets within tabs within a single Google Spreadsheet doc (rather than extending a global Questions doc with translated columns).

For local sites where more than one language is supported, the multi-column translation strategy can still be used.
@brew brew added this to the Survey Post-Launch milestone Nov 28, 2016
@brew brew mentioned this issue Nov 29, 2016
Closed
3 tasks
@brew brew mentioned this issue Dec 7, 2016
Open
brew added a commit that referenced this issue Dec 7, 2016
@brew
[#844] Add localization attributes to base template
3bd7a56
brew added a commit that referenced this issue Dec 7, 2016
@brew
[#844] Fix gulp script to extract i18n strings
cc552e6 
Was pointing to old template directory and needed to include more
special handling of 'or' use in nunjucks templates.

Also, don't extract from `format` keyword. Instead use `gettext` within
format function where approparite. Otherwise, some unnecessary strings
are extracted, like url concatenation.
brew added a commit that referenced this issue Dec 7, 2016
@brew
[#844] Mark strings for translation within templates
085abad 
And extract strings to messages.pot template.
brew added a commit that referenced this issue Dec 7, 2016
@brew
[#844] Fix path to gulp in README instructions
45089d3
brew added a commit that referenced this issue Dec 8, 2016
@brew
[#844] ES6 style changes to gulpfile.js
765c472
brew added a commit that referenced this issue Dec 8, 2016
@brew
[#844] Extract i18n strings from js files
ef09ae5 
Use gulp-filter to treat html and js files separately. Exclude some
directories as sources for the pipeline to speed things up a little.
brew added a commit that referenced this issue Dec 8, 2016
@brew
[#844] Mark strings for i18n in js files.
29e3f8b
brew added a commit that referenced this issue Dec 8, 2016
@brew
[#844] Manually add pot headers
6ceb4b4 
These get lost when concatenating the pot files together, so manually
add the defaults.
brew added a commit that referenced this issue Dec 8, 2016
@brew
[#844] Regenerate pot file from html/js marked strings
08aaf9c
@brew brew mentioned this issue Dec 8, 2016
Merged
brew added a commit that referenced this issue Dec 8, 2016
@brew
[#844] Fix gettext in create template.
6e48df4 
Execution order means I can't include nunjucks markup in gettext calls.
brew added a commit that referenced this issue Dec 8, 2016
@brew
[#844] Don't call gettext from 500 controller
b9fec36 
Keeping the 500 controller action simple.
brew added a commit that referenced this issue Dec 9, 2016
@brew
[#844] Add locale to req.params.
aaa21ae 
This is used when retrieving data to determine whether and which
translations to use.
brew added a commit that referenced this issue Dec 9, 2016
@brew
[#844] Fix translated method
8346b45 
- use arrow function to `this` is scoped correctly
- use `get` for the sequelized object, which doesn't support
  `hasOwnProperty`.
brew added a commit that referenced this issue Dec 9, 2016
@brew
[#844] Use req.locale to set locale in data options
b2b4925 
`req.params.locale` doesn't get changed by the language switcher.
brew added a commit that referenced this issue Dec 9, 2016
@brew
[#844] Load dataset.name in preference to .title
877b720 
The database uses `name` as the field to hold the title value. So the
`title` column in the CMS was mapped to the db `name` field. This meant
`Title@LC` translation columns in the CMS didn't work as expected. This
commit updates the MigrationNotes doc to warn that `Name` should be used
in the CMS instead of `Title`. Title is still loadable, but won't be
translatable.
brew added a commit that referenced this issue Dec 9, 2016
@brew
[#844] Ensure there's a translated value
91545c1 
If the translated entry is empty, don't use the translation, falling
back to the default value.
brew added a commit that referenced this issue Dec 9, 2016
@brew
[#844] ES6 style for localization tests
2fc5c2f
brew added a commit that referenced this issue Dec 9, 2016
@brew
[#844] Add test asserts for translated content
541ec3d 
Content loaded from the CMS is translated correctly.
This was referenced Dec 9, 2016
Merged
Merged
brew added a commit that referenced this issue Dec 13, 2016
@brew
[#844] Update site-admin docs
99551c8 
- localization
- new site config setttings
- typos and sentence fixes
- location of new template spreadsheet
brew added a commit that referenced this issue Dec 13, 2016
@brew
[#844] Update README and settings template
3d75776 
- update Registry spreadsheet url
- various typos and sentence fixes
@brew brew mentioned this issue Dec 13, 2016
Merged
@brew brew self-assigned this Dec 13, 2016
@brew brew mentioned this issue Dec 13, 2016
Open
@brew brew closed this as completed Dec 15, 2016
@brew brew mentioned this issue Jan 6, 2017
Open
@snyk-bot snyk-bot mentioned this issue Apr 27, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brew brew

Labels
None yet
Projects
None yet
Milestone
Survey site Post-Launch - do not add ...
Development

No branches or pull requests
1 participant
@brew