-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recline Slickgrid view supports editing #384
Comments
Most of what is needed is already there - see https://github.com/okfn/recline/blob/master/src/view.slickgrid.js#L26 We just need to:
|
Hi Ruffus , I Happy to work to perform recline js and to fix above problems, I' am 1 - If The fisrt cell contain % we bind a PercentType to field With this solution I Have some question how we can guess an type like editor: Slick.Editors.Checkbox I think that I simple Hack Here https://github.com/okfn/recline/blob/master/src/view.slickgrid.js#L112 --Ad |
@aliounedia i'd suggest we just run off the field types we have - see http://okfnlabs.org/recline/docs/models.html#types and https://github.com/okfn/recline/blob/master/src/model.js#L384 With fallback if no type specified to (text field or long text field). I don't think we want to try to guess from the data at this point (that is a useful task - to infer field types from data - but should be separate (and it is not easy!)). |
@aliounedia did the above make sense - would love to have you as a contributor here so let me know if I should make further suggestions ... |
@rgrp I 'will make some pull request soon , maybe tonight based on your suggestion , have you any ideas http://okfnlabs.org/recline/docs/models.html#types ? |
…eld type. * multiview demo now has editing turned on * [license][xs]: update to 2011-2014.
@aliounedia I've actually pushed some changes that address this a bit (see just above) - take a look to see how this is working. However, it would be nice to add e.g. validators or to have date editor work properly (e.g. respect date formatting (yyyy-mm-dd by default i guess). We also need to support onAddNewRow (and enableAddRow). Separately, it would be nice to enhance the demo so that it reports the changes you've made (illustrating how to subscribe to changes) - we probably want to think about whether we auto-sync changes or not ... |
grp Ok for me me this is exactly what I had done , Thank to push it , I will check the formating and row add/delete points , I will back if I have any questions |
@rgrp Hi Ruffus I have added a validtor for field format , aliounedia@dc24909 |
[#384] add validator to validate user input.
@aliounedia I think we're just about done here :-) Would you be interested in getting this integrated into Data Explorer - see rufuspollock-okfn/dataexplorer#154 |
@rgrp I am working Tonight for okfn senegal community to help |
|
FIXED. |
Should be quite straightforward.
See http://mleibman.github.io/SlickGrid/examples/example3-editing.html
The text was updated successfully, but these errors were encountered: