BackboneJS >0.9.9 doesn't accept model.set(other_model) anymore

[vitorbaptista]

As per the changelog at http://backbonejs.org/:

0.9.9

...
Model#set no longer accepts another model as an argument. This leads to subtle problems and is easily replaced with model.set(other.attributes).

We updated to 1.0.0 at 0801882 but forgot to do these changes, so there're a few places where Recline is failing silently. Using grep -rn "\.set(" src/ and filtering out valid uses, I got:

src/model.js:93:      self.set(results.metadata);
src/model.js:194:      this.queryState.set(queryObj, {silent: true});
src/view.multiview.js:230:    this.model.queryState.set(self.state.get('query'), {silent: true});
src/view.multiview.js:392:        self.state.set(update);
src/view.multiview.js:397:          self.state.set(update, {silent: true});
src/view.grid.js:244:    this.model.set(newData);
src/view.map.js:101:      self.state.set(self.menu.state.toJSON());
src/view.map.js:423:      this.menu.state.set(this.state.toJSON());
src/view.flot.js:62:      self.state.set(self.editor.state.toJSON());
src/view.flot.js:481:    this.state.set(updatedState);
src/view.slickgrid.js:304:      this.grid.setSortColumn(column, sortAsc);
src/view.slickgrid.js:312:    self.grid.setSelectionModel(new Slick.RowSelectionModel());
src/view.slickgrid.js:404:      model.set(v);

Not all of these lines are errors, but we'll need to double check.

[rufuspollock]

Great spot and annoying tests did not catch this change. Do you want to try patching or would you like someone else to take a quick look? (Happy either way)

[vitorbaptista]

I'll need this fixed for ckan/ckan#1251. If someone else is able to do it before me, great! If not, I'll do it 👍