Upgrade to bootstrap 3 #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MSolv this is great! |
rufuspollock
added a commit
that referenced
this pull request
Mar 5, 2015
Upgrade to bootstrap 3 - fixes #427.
|
Hi one question on this merge: I note jquery is still at v1.7. I note bootstrap JS needs jquery >= 1.10 IIRC. Have you looked at bumping jquery and seeing if everything still works. I anticipate we'll need an upgrade to slickgrid for this to work - see: mleibman/SlickGrid#518 A monkey patch is: mleibman/SlickGrid#518 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap 3.2.0 was added.
(I included a lot of changes implemented by @marks on his branch but forked from okfn/recline to start with everything up to date).
How I tested it:
What's pending:
Improve the usage of the grid system on multiview.