Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean no longer used cms_homepage.html template. #1017

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Nov 30, 2023

Current homepage uses the Default Layout making cms_homepage.html obsolete.

This PR cleans the template and all assets that were exclusively for it.

This PR is an effort to start cleaning our front-end dependencies #883 . I will first start by removing what it is no longer needed in the system.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (930060f) 88.61% compared to head (c1192e9) 88.61%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1017   +/-   ##
========================================
  Coverage    88.61%   88.61%           
========================================
  Files           97       97           
  Lines         1203     1203           
  Branches        49       49           
========================================
  Hits          1066     1066           
  Misses         135      135           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdelboca pdelboca merged commit 2b0edf6 into develop Dec 1, 2023
2 checks passed
@pdelboca pdelboca deleted the remove-obsolete-homepage-layout branch December 1, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants