Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#883 Clean up old frontend stuff #1019

Merged
merged 13 commits into from
Dec 1, 2023
Merged

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Dec 1, 2023

This is a PR to cleanup old parts of our frontend that are no longer relevant.

I tried to make isolated and descriptive commints, but I will add some extra details.

Details

  • bee2cc5 is no longer needed since we do not need custom body attributes.
  • 665f690 we are using Tailwind, so body classes are not required. Plus, those classes do not exist in our codebase anymore.
  • de93899 we only have 1 compiled javascript asset. Custom blocks to render custom js is not required anymore
  • head-alternate and head-links blocks are not required
  • 2749fa0 template-js block is no longer needed. Carousel no longer exist and the slider functinoality is handled in our main js module.
  • cef0287 We do not have breadcrumb in the site
  • 92822ca django-compressor is not needed anymore. Our assets are compiled by npm.
  • 137462b QUOTE_STYLE should have been cleaned in a previous cleanup: 6d1e9b2

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b0edf6) 88.61% compared to head (137462b) 88.61%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1019   +/-   ##
========================================
  Coverage    88.61%   88.61%           
========================================
  Files           97       97           
  Lines         1203     1203           
  Branches        49       49           
========================================
  Hits          1066     1066           
  Misses         135      135           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdelboca pdelboca merged commit 6bca3fa into develop Dec 1, 2023
2 checks passed
@pdelboca pdelboca deleted the clean-up-old-frontend-stuff branch December 1, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants