Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IFrame plugin #1051

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Add IFrame plugin #1051

merged 4 commits into from
Jan 11, 2024

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Jan 9, 2024

This plugin allows to embed a full width iframe.

Screenshots

Screenshot 2024-01-09 at 16-48-18 Testing Timeline
image

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b028d2) 88.61% compared to head (ac61be4) 88.78%.
Report is 11 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1051      +/-   ##
===========================================
+ Coverage    88.61%   88.78%   +0.17%     
===========================================
  Files           97       99       +2     
  Lines         1203     1222      +19     
  Branches        49       50       +1     
===========================================
+ Hits          1066     1085      +19     
  Misses         135      135              
  Partials         2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdelboca pdelboca merged commit 4cb1208 into develop Jan 11, 2024
2 checks passed
@pdelboca pdelboca deleted the iframe-plugin branch January 11, 2024 14:16
@lucpretti
Copy link
Contributor

@pdelboca @avdata99 El plugin works just great: https://next.okfn.org/en/testing-timeline/

Please deploy it to PRD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants