Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerfile #406

Merged
merged 24 commits into from Jun 26, 2018
Merged

Added dockerfile #406

merged 24 commits into from Jun 26, 2018

Conversation

roll
Copy link
Contributor

@roll roll commented Jun 13, 2018

No description provided.

@coveralls
Copy link

coveralls commented Jun 13, 2018

Coverage Status

Coverage remained the same at 88.982% when pulling 7039925 on dockerfile into 27aff44 on master.

@roll roll mentioned this pull request Jun 19, 2018
4 tasks
@roll roll changed the title [WIP] Added dockerfile Added dockerfile Jun 22, 2018
@roll roll mentioned this pull request Jun 22, 2018
@roll roll requested review from smth and serahkiburu June 22, 2018 14:51
@roll
Copy link
Contributor Author

roll commented Jun 22, 2018

@smth
@serahrono
Please take a look.

Esp. on the Dockerfile. I'm wondering is it enough commands to setup and run the app. Or we need more (like python manage.py collectstatic):

pip install -r requirements.txt
npm install -g bower
bower install --allow-root

python manage.py migrate && \
python manage.py update_index && \
gunicorn foundation.wsgi:application \ 
    --access-logfile '-' \ 
    --error-logfile '-'

It seems everything works OK using code from this PR:

@smth
Copy link
Contributor

smth commented Jun 25, 2018

I'll have to defer to @serahrono on this one @roll

@roll roll merged commit 58c287b into master Jun 26, 2018
@roll roll deleted the dockerfile branch June 26, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants