Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get models and migrations into line #480

Merged
merged 2 commits into from Oct 30, 2020
Merged

Get models and migrations into line #480

merged 2 commits into from Oct 30, 2020

Conversation

chris48s
Copy link
Member

Closes #479

Having spend a bit of time on this, it turns out there are 2 things going on here:

  1. Adding explicit related_name field (this will have been related to one of the django upgrades)
  2. Changing default values/descriptions etc from b'value' to 'value' (which will be something I missed in the python 3 upgrade).

I've also added a CI check to catch this in future.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.532% when pulling 6474557 on 479-migrations into 4fae9b7 on master.

@chris48s chris48s merged commit 18da4e9 into master Oct 30, 2020
@avdata99 avdata99 deleted the 479-migrations branch March 28, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get models and migrations into line
2 participants