-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
875 - Contact Form #894
875 - Contact Form #894
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #894 +/- ##
========================================
Coverage 89.14% 89.14%
========================================
Files 98 98
Lines 1345 1345
Branches 51 51
========================================
Hits 1199 1199
Misses 144 144
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just a couple notes:
- I don't like we are just sending emails after potential clients fill the form. We do not save this anywhere. This is not important for this PR but it's a problem
- We need to clean production an test environment settings in google
Co-authored-by: Andres Vazquez <andres@data99.com.ar>
Thanks for deploying it to develop @pdelboca! After reviewing it here https://next.okfn.org/contact/, I found a few minor changes for a better UX:
|
Implements #875
TODO:
Preview