Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

875 - Contact Form #894

Merged
merged 13 commits into from
Jul 18, 2023
Merged

875 - Contact Form #894

merged 13 commits into from
Jul 18, 2023

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Jul 10, 2023

Implements #875

TODO:

Preview

image

@pdelboca pdelboca marked this pull request as ready for review July 13, 2023 04:47
@pdelboca pdelboca requested a review from avdata99 July 13, 2023 04:47
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (073278b) 89.14% compared to head (b59ec34) 89.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #894   +/-   ##
========================================
  Coverage    89.14%   89.14%           
========================================
  Files           98       98           
  Lines         1345     1345           
  Branches        51       51           
========================================
  Hits          1199     1199           
  Misses         144      144           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

foundation/settings.py Outdated Show resolved Hide resolved
Copy link
Member

@avdata99 avdata99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just a couple notes:

  • I don't like we are just sending emails after potential clients fill the form. We do not save this anywhere. This is not important for this PR but it's a problem
  • We need to clean production an test environment settings in google

@pdelboca pdelboca merged commit bb24600 into develop Jul 18, 2023
2 checks passed
@lucpretti
Copy link
Contributor

lucpretti commented Jul 18, 2023

Thanks for deploying it to develop @pdelboca!

After reviewing it here https://next.okfn.org/contact/, I found a few minor changes for a better UX:

  • Remove colons from all fields (e.g. it will be only Website, not Website:)

  • Add an asterisk to the fields Name and Email (e.g. Name* and Email*), as a way to identify required fields

  • Change Organization to Organisation (as in British spelling)

  • Add a text line between the Captcha and the Send button with the following text: By submitting this form you agree to our Privacy Policy (linking "Privacy Policy" to /privacy-policy/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants