Make following redirects opt in #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okigan
commented
Jun 23, 2021
awscurl/awscurl.py
Outdated
| @@ -65,7 +66,8 @@ def make_request(method, | |||
| secret_key, | |||
| security_token, | |||
| data_binary, | |||
| verify=True): | |||
| verify=True, | |||
| redirects=False): | |||
There was a problem hiding this comment.
allow_redirects seems clearer name for the parameter
okigan
commented
Jun 23, 2021
awscurl/awscurl.py
Outdated
| @@ -82,6 +84,7 @@ def make_request(method, | |||
| :param security_token: str | |||
| :param data_binary: bool | |||
| :param verify: bool | |||
| :param redirects: false | |||
There was a problem hiding this comment.
allow_redirects seems clearer name for the parameter
okigan
commented
Jun 23, 2021
awscurl/awscurl.py
Outdated
| @@ -320,14 +323,14 @@ def __now(): | |||
| return datetime.datetime.utcnow() | |||
|
|
|||
|
|
|||
| def __send_request(uri, data, headers, method, verify): | |||
| def __send_request(uri, data, headers, method, verify, redirects): | |||
There was a problem hiding this comment.
allow_redirects seems clearer name for the parameter
okigan
commented
Jun 23, 2021
awscurl/awscurl.py
Outdated
| @@ -433,6 +436,8 @@ def inner_main(argv): | |||
| # https://github.com/boto/botocore/blob/c76553d3158b083d818f88c898d8f6d7918478fd/botocore/credentials.py#L260-262 | |||
| parser.add_argument('--security_token', env_var='AWS_SECURITY_TOKEN') | |||
| parser.add_argument('--session_token', env_var='AWS_SESSION_TOKEN') | |||
| parser.add_argument('-f', '--follow-redirects', action='store_true', default=False, | |||
There was a problem hiding this comment.
in spirit of following curl, please see curl --help | grep Follow -- i think awscurl should follow curl's convention
okigan
commented
Jun 23, 2021
awscurl/awscurl.py
Outdated
|
|
||
| if args.include or IS_VERBOSE: | ||
| print(response.headers, end='\n\n') | ||
| print(json.dumps(dict(response.headers)), end='\n\n') |
There was a problem hiding this comment.
please dont change default output format
Following the example from `curl`, requests will now only follow redirects if the `-L` or `--location` flag is provided. Signed requests will error on most redirects to other AWS services because the redirect uri no longer matches the canonical uri in the signed request. Closes okigan#117
bibliotechy
force-pushed
the
follow-redirects
branch
from
7011c9a
to
78fb1a6
Compare
|
@okigan OK, addressed your comments and concerns and cleaned up the commit message a bit. Thanks! |
okigan
commented
Jun 23, 2021
|
I tried to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.