Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support fallback to instance credentials #63

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

okigan
Copy link
Owner

@okigan okigan commented Jun 12, 2019

Add support to fallback to instance credentials by using optionally installed botocore - this may change in future as the story for support of roles and MFA(s) still not clear (see #44)

@okigan
Copy link
Owner Author

okigan commented Jun 12, 2019

@tinyzimmer see this one

@tinyzimmer
Copy link

Yep this would work I think. Only thing to note is botocore will flip out if any of the envvars are set also since those take precedence over IAM instance profiles. But if someone was shooting for that functionality they probably wouldn't have them set to begin with.

@okigan okigan merged commit 51974c3 into master Jun 12, 2019
@okigan okigan mentioned this pull request Jun 12, 2019
@ereli-cb
Copy link

You probably want to add botocore to the requirements.txt file, as per #54

@okigan okigan deleted the feature/fallback_to_load_instance_credentials branch December 3, 2019 09:57
okigan added a commit that referenced this pull request Dec 21, 2019
…credentials

support fallback to instance credentials
okigan added a commit that referenced this pull request Dec 21, 2019
…credentials

support fallback to instance credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants