-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encode to support non-English text data #75
Conversation
Thanks -- Please add a unit test |
@okigan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Thank you! |
@okigan |
next day or two, thanks! |
"next day or two" did not account for the thanksgiving week -- hope everyone had a good break as v0.18 is now released and up on pypi, happy awscurling! |
I see 😅 No problem. Thank you very much! |
Add encode to support non-English text data
Add encode to support non-English text data
When I call awscurl 0.17 with non-English text data, it fails with the following UnicodeEncodeError.
It is because the data passed to
requests.request
method is not encoded.Please check this pull request. Thanks.