-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update response to no longer encode to utf-8; include tests indicating why #92
Conversation
@p5k6 thanks for pull request!!, seems it failed python 3.5 https://travis-ci.org/github/okigan/awscurl/jobs/737570548 (i'll check why the failure is not shown in github) |
@p5k6 hmm, python 3.5 may have dependencies issue for the test library which is unrelated -- please rebase your pull request onto master and re-push |
Done 😄 |
Wasn’t sure what breaks for python 2.7 - seems it’s missing encoding marker - made or for your branch.
It progressed more - check it out (python encoding is not fresh in my memory)
… On Oct 20, 2020, at 7:13 PM, Josh Stanfield ***@***.***> wrote:
Done 😄
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I'll have to take a look tomorrow. Spending some time with my family for a bit. Appreciate your help! |
I've updated the test to account for python 2 behavior. In Py2, encoding the unicode into an 8-bit string ( |
@p5k6 I believe file encoding marker still needs to be added like shown here: https://github.com/p5k6/awscurl/pull/1/files |
Ah yes - my fault there. Running the tests one more time, will push once they've passed 😀 |
updated |
Nice!, checks in github passed (https://github.com/okigan/awscurl/actions/runs/320251739), waiting for https://travis-ci.org/github/okigan/awscurl/builds/737771305 to complete |
@p5k6 new release is on pypi: https://pypi.org/project/awscurl/0.21/ macos/homebrew build would need to be updated (as a separate thread) |
awesome thank you! |
So - I (a long time ago) pinned my version to 0.17, and never got around to looking into this. Hence why i haven't really discussed much in #85. Apologies there, life just got in the way.
fwiw - my producer setup is the same as Matthew's noted here.
I dug in pretty deep today. Some notes:
application/json;charset=UTF-8
. This ensures the response object from requests has the correct encoding (though interestingly,apparent_encoding
(i.e.chardet.detect
did not do a great job of detecting the encoding, but that's spurious really).resp._content
was copied over from there, using an api gateway/lambda serverless app)Let me know if you have any questions/comments/concerns