fix(@okikio/native): 🐛 add url to request & timeout errors event

okikio · May 28, 2021 · 0be77c6 · 0be77c6
1 parent 9aeec2e
commit 0be77c6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -4,7 +4,8 @@
     "scss.validate": false,
     "conventionalCommits.scopes": [
         "demo",
-        "@okikio/animate"
+        "@okikio/animate",
+        "@okikio/native"
     ],
     "npm.packageManager": "pnpm"
 }
diff --git a/packages/native/README.md b/packages/native/README.md
@@ -594,7 +594,7 @@ e.g.
 
 ```ts
 // ...
-app.on("REQUEST_ERROR" | "TIMEOUT_ERROR", (err: Error) => {
+app.on("REQUEST_ERROR" | "TIMEOUT_ERROR", (err: Error, url: string) => {
     // ...
 })
 ```

diff --git a/packages/native/src/page.ts b/packages/native/src/page.ts
@@ -154,7 +154,7 @@ export class PageManager extends Service {
             window.clearTimeout(timeout);
 
             const err = new Error("Request Timed Out!");
-            this.emitter.emit("TIMEOUT_ERROR", err);
+            this.emitter.emit("TIMEOUT_ERROR", err, url);
             throw err;
         }, this.config.timeout);
 
@@ -172,7 +172,7 @@ export class PageManager extends Service {
                 return await response.text();
 
             const err = new Error(response.statusText || "" + response.status);
-            this.emitter.emit("REQUEST_ERROR", err);
+            this.emitter.emit("REQUEST_ERROR", err, url);
             throw err;
         } catch (err) {
             window.clearTimeout(timeout);