Allow to override build date with SOURCE_DATE_EPOCH #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This date call only works with GNU date. Also use UTC to be independent of timezone. Locales still can cause %B to vary. ISO 8601 date format would help there.
|
Thank you for the patch, Bernd! I've applied a slightly different change. I fixed it in https://github.com/okirch/microconf (and then rebuilt the microconf subdir in pcr-oracle) - making SOURCE_DATE_EPOCH do what you want it to do, but leaving the original code unchanged for how. I did a quick smoke test and it appears to work correctly. I'd appreciate a quick nod from your end if you agree :-) |
|
@bmwiedemann did you have an opportunity to check if my alternative fix addresses the issue correctly? |
|
I can confirm that the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to override build date with
SOURCE_DATE_EPOCHin order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable.
This date call only works with GNU date.
Also use UTC to be independent of timezone.
Locales still can cause
%Bto vary. ISO 8601 date format would help there.