Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception output is overwritten if there are failed checks in test #43

Closed
darthc9 opened this issue Sep 20, 2020 · 2 comments
Closed

Exception output is overwritten if there are failed checks in test #43

darthc9 opened this issue Sep 20, 2020 · 2 comments
Labels
bug

Comments

@darthc9
Copy link

darthc9 commented Sep 20, 2020

in the case of failed checks in the test, the hook pytest_runtest_makereport will overwrite report.longrepr instead of appending to it. but report.longrepr hold the output to be printed for the exception.

(if there are no failures naturally the hook does not overwrite this var and the output of the exception gets printed)
@antoche antoche mentioned this issue Sep 24, 2020
Closed
@okken
Copy link
Owner

okken commented Dec 14, 2020

seems bad. will try to look into soon-ish

@okken okken added the bug label Dec 14, 2020
@okken
Copy link
Owner

okken commented Dec 14, 2020

might be a dup of #44

@lhayhurst lhayhurst mentioned this issue Dec 26, 2020
Closed
@okken okken closed this as completed in dba2a9e Dec 27, 2020
okken added a commit that referenced this issue Dec 27, 2020
@okken
Merge pull request #48 from okken/dev
3ac4f48 
Fix #43/#44 tests with failing checks and failing asserts now report all issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okken @darthc9